autowarefoundation / autoware

Autoware - the world's leading open-source software project for autonomous driving
https://www.autoware.org/
Apache License 2.0
8.6k stars 2.89k forks source link

chore(webauto-ci): update architecture_type parameter for simulation #4098

Closed HansRobo closed 4 months ago

HansRobo commented 6 months ago

Description

Update architecture_type parameter for simulation

Related: https://github.com/tier4/scenario_simulator_v2/pull/1027

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

mitsudome-r commented 5 months ago

@HansRobo Thanks for the PR. Are there any drawbacks for changing the architecture, or is this improvement for traffic light scenarios?

mitsudome-r commented 4 months ago

At the moment, there seems to be no drawback so I'm approving the PR. (we might have to revert this once we port to autoware_msgs)