refactor: update ML model param files download - Githubissues

autowarefoundation / autoware

Autoware - the world's leading open-source software project for autonomous driving

https://www.autoware.org/

Apache License 2.0

8.59k stars 2.88k forks source link

refactor: update ML model param files download #4533

Closed badai-nguyen closed 2 months ago

badai-nguyen commented 3 months ago

Description

Related to Issue: https://github.com/autowarefoundation/autoware.universe/issues/6590 PR: https://github.com/autowarefoundation/autoware.universe/pull/6591
This PR should be merged together with https://github.com/autowarefoundation/autoware_launch/pull/915

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

xmfcx commented 2 months ago

@badai-nguyen could you please update the https://github.com/badai-nguyen/autoware/tree/d9e1668ba5412dbb9402e83e80166d722493abb5/ansible/roles/artifacts#readme file to match this too?

Right now it is not working for manual instruction followers.