When a user, who wants to continue operating Autoware on a specific version of "ros-distro-desktop", executes the setup-dev-env.sh with the ROS packages already held, the installation of ROS 2 fails, and all other installation roles , such as fetching the latest ONNX files, are not executed.
This PR changes is escaping the ROS 2 installation process and issuing a warning when it's already held.
Tests performed
Before testing, all of ROS packages are held.
Result of setup-dev-env.sh. Failed and other roles are not executed.
If ros-humble-desktop is held and other dependencies package is held.
install: skipped (OK)
warining: output (OK)
The ros-humble-desktop is not held and others is held.
install: changed (OK)
warining: skipped (OK)
Effects on system behavior
No
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
Naophis
commented
3 months ago
Description
When a user, who wants to continue operating Autoware on a specific version of "ros-distro-desktop", executes the
setup-dev-env.shwith the ROS packages already held, the installation of ROS 2 fails, and all other installation roles , such as fetching the latest ONNX files, are not executed.This PR changes is escaping the ROS 2 installation process and issuing a warning when it's already held.
Tests performed
setup-dev-env.sh. Failed and other roles are not executed.If
ros-humble-desktopis held and other dependencies package is held.The
ros-humble-desktopis not held and others is held.Effects on system behavior
No
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.