autowarefoundation / autoware

Autoware - the world's leading open-source software project for autonomous driving
https://www.autoware.org/
Apache License 2.0
8.59k stars 2.88k forks source link

feat: escape install task if the specific package is held #4585

Closed Naophis closed 3 months ago

Naophis commented 3 months ago

Description

When a user, who wants to continue operating Autoware on a specific version of "ros-distro-desktop", executes the setup-dev-env.sh with the ROS packages already held, the installation of ROS 2 fails, and all other installation roles , such as fetching the latest ONNX files, are not executed.

This PR changes is escaping the ROS 2 installation process and issuing a warning when it's already held.

Tests performed

  1. If ros-humble-desktop is held and other dependencies package is held.

    • install: skipped (OK)
    • warining: output (OK) Screenshot from 2024-04-02 15-59-55
  2. If ros-humble-desktop is not held and others is held.

    • install: changed (OK)
    • warining: skipped (OK) Screenshot from 2024-04-02 15-59-18

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.