autowarefoundation / autoware

Autoware - the world's leading open-source software project for autonomous driving
https://www.autoware.org/
Apache License 2.0
8.58k stars 2.88k forks source link

chore(docker): change the cmake's build tool from `make` to `ninja` #4658

Closed youtalk closed 1 month ago

youtalk commented 2 months ago

Description

This PR has changed the cmake's build tool from make to ninja. ninja is typically faster than make to rebuild modified source code. So when using cache properly, the ninja build time would be faster than make.

https://ninja-build.org/

The results of the colcon build time using my local PC are shown below. There may be a few overhead.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

youtalk commented 2 months ago

~Temporalily https://packages.microsoft.com/ubuntu/22.04/prod/dists/jammy/InRelease has no response. That's why setup-docker and setup-universe CI checks were failed.~ Resolved.

xmfcx commented 2 months ago

Is ninja installed on the system? Could you share the step that installs it?

youtalk commented 2 months ago

I couldn't find the step so that I've explicitly installed ninja-build. https://github.com/autowarefoundation/autoware/pull/4658/commits/158ff39afaf68a076fd76df53d2dbccb35bf74e2

@xmfcx Please review again.

xmfcx commented 1 month ago

@youtalk -san, why was this closed?

youtalk commented 1 month ago

@xmfcx Just no reason. I’ve reopened. Please review again.

xmfcx commented 1 month ago

@youtalk why did you remove it this time?

youtalk commented 1 month ago

Because no one reviews.