autowarefoundation / autoware

Autoware - the world's leading open-source software project for autonomous driving
https://www.autoware.org/
Apache License 2.0
8.58k stars 2.88k forks source link

refactor(docker): introduce src-imported stage #4709

Closed youtalk closed 1 month ago

youtalk commented 1 month ago

Description

This PR adds the src-imported stage to the top stage of the Dockerfile. This allows the base and src-imported stages to be processed in parallel, reducing the download latency of the vcs import command. It also eliminates the need to run the vcs import command again in the runtime stage. The trial in my local environment speeded up the docker build by about 5 minutes.

This PR does not cut out rosdep install, based on the reflection of the previous PR: https://github.com/autowarefoundation/autoware/pull/4656#issuecomment-2082095239

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

youtalk commented 1 month ago

@mitsudome-r Please merge it because I have no longer the write access anyhow.

xmfcx commented 1 month ago

How was this tested?

I can merge it but I'm worried it might break the containers since I didn't test it.

youtalk commented 1 month ago

@xmfcx How can I test the container? I'm sorry but I don't know the test function since I'm new.