search

autowarefoundation / autoware

Autoware - the world's leading open-source software project for autonomous driving
https://www.autoware.org/
Apache License 2.0
8.58k stars 2.88k forks source link

fix(docker): remove build main action #4747

Open oguzkaganozt opened 1 month ago

oguzkaganozt commented 1 month ago

Description

To simplify CI-CD pipeline ,build-main and build-main-self-hosted can be deleted because they are simply using the same docker build mechanism as docker-build-main and docker-build-main-self-hosted.

Also renaming of:

can be done since docker builds does not pushes every time into the registry the naming implies false positive.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

youtalk commented 1 month ago

We are using docker-build-and-push-main and docker-build-and-push-main-self-hosted for not only main branch but also the other branches. So are docker-build and docker-build-self-hosted better?

youtalk commented 4 weeks ago

@oguzkaganozt I think this PR is important for the workflow refactoring, so I took over and made the necessary modifications.

@xmfcx I've updated the schedule to every day and the README badge. Note that there is no docker-build workflow until this PR is merged, so no badge has been generated. Please review again.

xmfcx commented 4 weeks ago

But now the question is, do we want to update the base image and push it to registry every day?

I think there was a reason to do this twice a month. @mitsudome-r @youtalk

youtalk commented 4 weeks ago

Oh, I finally understood. The difference between build-main and docker-build-and-push-main is allow-push option. That's why it might not be suitable to run docker-build-and-push-main every day. @xmfcx I think so.

oguzkaganozt commented 1 week ago

@xmfcx @youtalk @mitsudome-r

Updated the PR so that; we are now using docker-buildand docker-build-self-hosted both for daily builds and pushing images to registry twice a month. Please review again.