search

autowarefoundation / autoware

Autoware - the world's leading open-source software project for autonomous driving
https://www.autoware.org/
Apache License 2.0
9k stars 3.01k forks source link

`docker-build-and-push-main` is failing #4879

Closed xmfcx closed 3 months ago

xmfcx commented 3 months ago

image

docker-build-and-push-main CI started failing after this was merged:

ERROR: tag is needed when pushing to registry
Error: buildx bake failed with: ERROR: tag is needed when pushing to registry

https://github.com/autowarefoundation/autoware/actions/runs/9516216183/job/26232045461#step:8:1288

@oguzkaganozt

Probabable cause

It has passed the test on the initial PR description:

Then, some tag related things were changed within the PR review process: https://github.com/autowarefoundation/autoware/pull/4849#discussion_r1638115734

To prevent such cases from happening, perform the tests again before merging.

Originally posted by @xmfcx in https://github.com/autowarefoundation/autoware/issues/4849#issuecomment-2171577155

xmfcx commented 3 months ago

@youtalk @oguzkaganozt @mitsudome-r I'll now start working on this task.

xmfcx commented 3 months ago

The test on the PR description passed:

But the workflow triggered by the commit pushed failed:

They use docker-build-and-push/action.yaml action.

The biggest difference I see between them is,

Trigger allow-push Workflow Status
workflow_dispatch false ✅
push to main true ❌

So the test doesn't cover the allow-push=true case.

I will investigate further.

xmfcx commented 3 months ago

https://github.com/autowarefoundation/autoware/actions/runs/9577390080

Still failing.

xmfcx commented 3 months ago

Since we no longer trigger this by the push event, it shouldn't be an issue anymore.