autowarefoundation / autoware

Autoware - the world's leading open-source software project for autonomous driving
https://www.autoware.org/
Apache License 2.0
9k stars 3.01k forks source link

ci(docker-build-and-push): add base tag to fix failure #4886

Closed xmfcx closed 3 months ago

xmfcx commented 3 months ago

Description

Fixes:

Tests performed

To test this, I've created this tag temporarily:

Workflow triggered by that tag push:

And tag is under push condition so it should test it very comprehensively. I don't know if it will have any side effects but we'll see. I'll remove the images once this PR is merged.

🎈🎈🎈🎈Success

🖱️Click here to expand🔛 ![brave_z9LOOMDVh5](https://github.com/autowarefoundation/autoware/assets/10751153/3981a69f-04de-4c76-a8dc-6610cb1383ab) ![screencapture-github-autowarefoundation-autoware-pkgs-container-autoware-versions-2024-06-18-22_22_15](https://github.com/autowarefoundation/autoware/assets/10751153/492b168b-735d-4dac-bb39-a47ed04036e6)

Effects on system behavior

Hopefully CI starts working again.

Interface changes

None.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

xmfcx commented 3 months ago

🎈🎈🎈🎈Success

🖱️Click here to expand🔛 ![brave_z9LOOMDVh5](https://github.com/autowarefoundation/autoware/assets/10751153/3981a69f-04de-4c76-a8dc-6610cb1383ab) ![screencapture-github-autowarefoundation-autoware-pkgs-container-autoware-versions-2024-06-18-22_22_15](https://github.com/autowarefoundation/autoware/assets/10751153/492b168b-735d-4dac-bb39-a47ed04036e6)

@youtalk @oguzkaganozt this is ready for review, it seems to have succeed building and pushing the image.

xmfcx commented 3 months ago

@youtalk san thank you for the review!

xmfcx commented 3 months ago

Failed again 🤣 : https://github.com/autowarefoundation/autoware/actions/runs/9577390080