chore(ci): add separate .clang-tidy-ci file

veqcc commented 5 days ago

Description

This is the first step to achive the proposal: https://github.com/orgs/autowarefoundation/discussions/4876 .

I have made the following changes:

make a new clang-tidy configuration file clang-tidy-ci for CI workflow
- It checks the same warnings as it is, while severity HIGH and MEDIUM warnings are treated as errors, which will prevent each PR from being merged when it contains HIGH and MEDIUM warnings
delete the outdated feature AnalyzeTemporaryDtors: false
delete the default setting FormatStyle: none

Checks and CheckOptions are exactly the same as original.

After this PR is merged, then each PR in autoware.universe would pass clang-tidy-differential workflow, unless it invokes new warnings.

Tests performed

The clang-tidy warnings are obtained in tier4 universe v0.29.0: https://github.com/tier4/autoware.universe/tree/v0.29.0 .

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

mojomex commented 5 days ago

@veqcc Hi! I just commented on the discussion page because this PR would break my in-IDE code analysis/style checks. Please review when you have time :pray:

mitsudome-r commented 5 days ago

Is the plan to add the same file in autoware.universe as well once this is merged?

xmfcx commented 5 days ago

@mitsudome-r

https://github.com/autowarefoundation/autoware.universe/blob/23d857d1c072525422a49f6ac6ec9364235bc55f/.github/workflows/clang-tidy-differential.yaml#L51

they are using this file here. No need to change in universe.

autowarefoundation / autoware