Twist Gate Refactor - Githubissues

autowarefoundation / autoware_ai_planning

Apache License 2.0

210 stars 148 forks source link

Twist Gate Refactor #40

Closed icolwell-as closed 3 years ago

icolwell-as commented 3 years ago

Removed remote control functionality.
Removed main loop so that commands are passed through immediately.
Other small cleanups and refactors.

See original MR for more details: https://gitlab.com/astuff/autoware.ai/core_planning/-/merge_requests/84

JWhitleyWork commented 3 years ago

@icolwell-as I'm not a big fan of removing existing APIs without a lot of discussion with the community, especially in the last feature release of the software. Could AStuff reformat this MR to leave that functionality but provide the other improvements?

icolwell-as commented 3 years ago

Unfortunately, removing the remote command capabilities is what made it much easier to streamline/simplify the operation of this node. I'll leave this PR open and take a closer look later to see how much additional work would be required.

JWhitleyWork commented 3 years ago

@icolwell-as Any updates?

icolwell-as commented 3 years ago

Hi @JWhitleyWork, I think I'll close this PR. In retrospect it was mostly tailored to our specific use case and may not be appropriate for the wider community. Also, we don't really have a clear understanding of the remote control use case in order to make sure its re-implemented and fully tested along with the other control input types. Thanks!

JWhitleyWork commented 3 years ago

Thanks, @icolwell-as.