autowarefoundation / autoware_lanelet2_extension

Extension library of Lanelet2
Apache License 2.0
1 stars 10 forks source link

refactor: remove redundant cmake definition #13

Closed wep21 closed 4 months ago

wep21 commented 4 months ago

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.93%. Comparing base (a586d15) to head (203b61a). Report is 1 commits behind head on main.

:exclamation: Current head 203b61a differs from pull request most recent head 01df65c

Please upload reports for the commit 01df65c to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #13 +/- ## ======================================= Coverage 15.93% 15.93% ======================================= Files 40 40 Lines 2748 2748 Branches 1339 1340 +1 ======================================= Hits 438 438 Misses 2222 2222 Partials 88 88 ``` | [Flag](https://app.codecov.io/gh/autowarefoundation/autoware_lanelet2_extension/pull/13/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | Coverage Δ | | |---|---|---| | [differential](https://app.codecov.io/gh/autowarefoundation/autoware_lanelet2_extension/pull/13/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `15.93% <ø> (ø)` | | | [total](https://app.codecov.io/gh/autowarefoundation/autoware_lanelet2_extension/pull/13/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=autowarefoundation) | `?` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

youtalk commented 4 months ago

LGTM But we need to fix the cpplint problem https://results.pre-commit.ci/run/github/791833089/1719813784.vF-W1qiuSbyweopfbpNS9Q. @wep21 Could you fix them?

This was solved by https://github.com/autowarefoundation/autoware_lanelet2_extension/pull/15.