autowarefoundation / autoware_launch

Apache License 2.0
29 stars 261 forks source link

feat(psim)!: change a setting parameter type from bool to string #1106

Closed yuki-takagi-66 closed 1 month ago

yuki-takagi-66 commented 2 months ago

Description

This PR changes a configuration variable from a bool type to a string type to allow more flexibility in configuring the localization module to be activated in psim. This PR does not change the behavior.

This PR is a part of the following issue, and a new mode will be added in a few weeks. https://github.com/autowarefoundation/autoware_launch/issues/1100

universe PR: https://github.com/autowarefoundation/autoware.universe/pull/8331

Tests performed

In psim, we verified that the activated nodes are properly switched. There was also no problem in executing scenario_sim. internal link: https://evaluation.tier4.jp/evaluation/reports/bc29eeab-daa3-55e1-8446-400bdb049517?project_id=prd_jt

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

After all checkboxes are checked, anyone who has write access can merge the PR.

yuki-takagi-66 commented 1 month ago

@mitsudome-r @yukkysaito Thank you for the suggestions. I have updated the code corresponding to the comments. https://github.com/autowarefoundation/autoware_launch/pull/1106/commits/93d3715d8fa31c66c36f04956b081abea9427f33