autowarefoundation / autoware_launch

Apache License 2.0
27 stars 223 forks source link

Discuss the diagnostics name for logger #212

Open kenji-miyake opened 1 year ago

kenji-miyake commented 1 year ago

Checklist

Description

As described in https://github.com/autowarefoundation/autoware_launch/pull/211#discussion_r1109145181, it's the name of TIER IV's logger. I concern that it might not be suitable for the AWF because the AWF's configurations/interfaces should be generic and diagnostic names can be said to be interfaces of Autoware.

Purpose

To make Autoware's interfaces more generic so that people can easily use/extend it.

Possible approaches

Definition of done

kenji-miyake commented 1 year ago

@xmfcx @mitsudome-r @yukkysaito @ito-san @asana17 What do you think about it?

mitsudome-r commented 1 year ago

Possible candidates:

"logger" could be "recorder" as well.

ito-san commented 1 year ago

The bagpacker and related diagnostics are specific to TIER IV, so I second removing it.

asana17 commented 1 year ago

I agree with removing the logger from the AWF configuration. It is better to add diagnostics as the general logger function interface is defined.

stale[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity.