feat(lanelet2_map_validator): add test codes for existing validators

TaikiYamada4 commented 1 week ago

Description

This PR revises the test system in lanelet2_map_validator such like

Split the test code for each validator
Added small maps to validate each issue detection.
Added medium size map to check validation works well with normal maps

I made the medium size map (sample_map.osm) by modifying lanelet2_map.osm from autoware_test_utils. I modified that map so that the current requirements in the autoware_requirement_set.json will pass.

Tests performed

1. Test codes

I tested the test codes through

colcon test --event-handlers console_cohesion+ --packages-select autoware_lanelet2_map_validator

2. Test sample_map.osm

I tested that sample_map.osm passes vm-02-02, vm-04-01 and vm-05-01 through the following command.

ros2 run autoware_lanelet2_map_validator autoware_lanelet2_map_validator -p mgrs -m ./install/autoware_lanelet2_map_validator/share/autoware_lanelet2_map_validator/data/map/sample_map.osm -i ./src/autoware_tools/map/autoware_lanelet2_map_validator/autoware_requirement_set.json -o ./

The figure below is the console output I got. Screenshot from 2024-11-15 11-41-50

Notes for reviewers

None

Interface changes

None

Effects on system behavior

Test algorithm changed.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

TaikiYamada4 commented 1 week ago

@YamatoAndo Thanks for your review! All three suggestions above are fixed in here https://github.com/autowarefoundation/autoware_tools/pull/150/commits/2b3cfe81e15d59ff1c3227784b7f6d8b07e9ca21

TaikiYamada4 commented 1 week ago

@YamatoAndo I've fixed the sample_map.osm crosswalk_polygon to detection_area so please check it out.

autowarefoundation / autoware_tools