revert: "fix previously received data remains"

autowarefoundation / ros2_socketcan

A ROS2 wrapper around Linux SocketCAN

Apache License 2.0

119 stars 58 forks source link

revert: "fix previously received data remains" #19

Closed wep21 closed 2 years ago

wep21 commented 2 years ago

Reverts autowarefoundation/ros2_socketcan#18 I think we need further discussions to merge #18.

mitsudome-r commented 2 years ago

Background of this PR

Regarding PR https://github.com/autowarefoundation/ros2_socketcan/pull/18, I have talked with @a-higuchi and @yn-mrse and wasn't convinced that the change is appropriate for the proposed issue. Since the change could potentially cause another issue to other users, I've asked @wep21 to create a revert PR. (Process wise, I should've commented to the PR much earlier before it was merged so the blame is on me.)

JWhitleyWork commented 2 years ago

Now that I read the description/use-case for #18, I see that it's pretty niche as well. Thanks for reviewing this more thoroughly.