autozimu / LanguageClient-neovim

Language Server Protocol (LSP) support for vim and neovim.
MIT License
3.55k stars 273 forks source link

Support Diagnostic.source #1062

Closed 110y closed 4 years ago

110y commented 4 years ago

Add Diagnostic.source to diagnostic text.

Background

In case of gopls, which is the language server for Go, it populates Diagnostic.source with the analyzer (linter) name which we violate the rules. So at least for gopls, the Diagnostic.source is necessary information for coding.

Fix #296

martskins commented 4 years ago

Nice! Just a small fix needed, contributions should now target the dev branch, so if you can change this PR to target that I think we're good to go.

110y commented 4 years ago

@martskins

Thanks! Rebased the branch to dev.

martskins commented 4 years ago

Thank you!