autozimu / LanguageClient-neovim

Language Server Protocol (LSP) support for vim and neovim.
MIT License
3.55k stars 273 forks source link

Remove unnecessary calls to didChange #1119

Open martskins opened 3 years ago

martskins commented 3 years ago

I'm not quite sure if this is correct, but all those calls to text_document_did_change seemed unnecessary to me. While removing those I also noticed that our handle_text_change function doesn't really do anything, it used to have a call to text_document_did_change but at some point that got deleted, and it seems to me like we want to have that there, especially if we're removing the other calls.

This also lets us remove the text parameter from the functions that don't really need it, reducing the size of the message considerably.