Change LanguageClient#complete to not use runSync

autozimu / LanguageClient-neovim

Language Server Protocol (LSP) support for vim and neovim.

MIT License

3.55k stars 272 forks source link

Change LanguageClient#complete to not use runSync #1170

Open martskins opened 3 years ago

martskins commented 3 years ago

This PR changes LanguageClient#complete to use a callback instead of LanguageClient#runSync to get the completion items so that a misbehaving server (one that does not reply or takes too long to reply) doesn't hang the editor for 60 seconds.

Fixes #1169

martskins commented 3 years ago

This has an issue with expanding completion item snippets. It doesn't work when you try to do that after <C-X><C-O>, trying to figure this out now.