autozimu / LanguageClient-neovim

Language Server Protocol (LSP) support for vim and neovim.
MIT License
3.55k stars 272 forks source link

Highlights don't go away when other files changes. #1214

Open EvanCarroll opened 3 years ago

EvanCarroll commented 3 years ago

If I have an error like,

[Error] [E0624] associated function get_as_store is private private associated function

caused by,

let alerts = client.get_as_store().await.expect("Got JSON");

And then I go to the definition of get_as_store() and pub, the error goes away. But the highlighting behind the error does not go away.

martskins commented 3 years ago

Please try and stick to the issue template, you don't have to have an answer for all of them and maybe your description doesn't fit the template that well, but for most cases you'll need to answer those questions eventually anyways, so might as well save some time and start with those answers when you open the issue.

Which language server (and version of it) are you using? Which version of LanguageClient-neovim? (dev or next?) Are you able to reproduce and submit a minimal reproducible example? (including a minimal vimrc for that example) Are you using vim or neovim?

EvanCarroll commented 3 years ago

I actually don't think this is specific to that issue. It seems to happen a lot where the background doesn't get unhighlighted without restarting vim.

$ /home/ecarroll/.vim/plugged/LanguageClient-neovim/bin/languageclient --version
languageclient 0.1.161

$ rust-analyzer --version
rust-analyzer nightly

$ vim --version
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Mar 02 2021 02:58:09)
Included patches: 1-2434

I'll work on reproducing the issue later, if this is new.

martskins commented 3 years ago

I don't know what issue you are referring to. I meant that there's a github issue template when you report one, and that sticking to it saves this back and forth of questions about your environment and such, because those questions are asked in the issue template, but in any case, not sure if you are running the dev or next branch of LanguageClient-neovim, but if you are running the next branch can you try dev ? I've recently merged something in that branch that might be the fix for what you are seeing.

Remember that to run the dev branch you need to change the branch in your plugin config but also build LanguageClient-neovim from source, so you'll need to run make release (and have rust installed which you seem to have already).