search

autozimu / LanguageClient-neovim

Language Server Protocol (LSP) support for vim and neovim.
MIT License
3.55k stars 273 forks source link

vim-plug :PlugStatus reports LanguageClient-neovim as broken #239

Closed nponeccop closed 6 years ago

nponeccop commented 6 years ago

and recommends reinstallation:

- yats.vim: OK                                                                            |~
- deoplete.nvim: OK                                                                       |~
x LanguageClient-neovim:                                                                  |~
    Diverged from origin/master (186 commit(s) ahead and 13 commit(s) behind!             |~
    Backup local changes and run PlugClean and PlugUpdate to reinstall it.                |~

And the suggested reinstallation steps don't help. Also :PlugUpdate didn't update to a newer tag (but I can't reproduce that anymore).

These ones are likely upstream bugs in vim-plug, but I know too little about nvim/vimplug to report them and to help with reproduction.

I use neovim

meck commented 6 years ago

Definitely Vim-Plug, looks like defaults to master branch for the statuscheck when you specify a tag Plug 'autozimu/LanguageClient-neovim', { 'tag': 'binary-*-x86_64-apple-darwin', 'branch': 'next' } made it compare to next, but I could not get it to compare to a tag, but it only seems to be the status check, the checkout and update seem fine.

gadkadosh commented 6 years ago

Moreover, vim-plug doesn't update the plugin anymore when doing :PlugUpdate. I guess it doesn't check for newer tags matching the 'tag' property. There should maybe be a warning about that in the docs/install instructions.

deathmaz commented 6 years ago

It is possible to update the plugin via :PlugClean and :PlugUpdate

deathmaz commented 6 years ago

though i don't think its a good way of doing this

gadkadosh commented 6 years ago

That's what I'm doing. Kind of defeats the point of using a plugin manager.

autozimu commented 6 years ago

I believe this is a vim-plug issue. Created a issue https://github.com/junegunn/vim-plug/issues/719

ahmedelgabri commented 6 years ago

Although it's a vim-plug issue, I think it might be better if we have a better way of distribution.

Because you are now tightly coupling the usage of the LanguageClient-neovim with vim-plug, what if someone is using minpac or something else... how can they use the plugin with their plugin manager of choice? Especially that idea of a wild card might not be in some of these plugin managers too.

autozimu commented 6 years ago

The recommended installation is changed to install.sh based, which should work with most vim plugin.