search

autumnai / collenchyma

Extendable HPC-Framework for CUDA, OpenCL and common CPU
http://autumnai.github.io/collenchyma
Apache License 2.0
475 stars 33 forks source link

Use size types that depend on the target architecture. #24

Closed pdib closed 8 years ago

pdib commented 8 years ago

The build broke on my side, due to a mismatched type between u32 and u64 in the cuda bindings

This replaces u32 and u64 with usize (or libc::size_t) where the expected type is a pointer size. It should make the build more robust over different target architectures.

MichaelHirn commented 8 years ago

Excellent timing. We were just about to release 0.0.5 with feature build support for native, cuda and opencl.

Code looks good; tests and build succeeded, so it will be available with 0.0.5 in a minute.

Thank you very much, @pdib

MichaelHirn commented 8 years ago

@homu r+

homu commented 8 years ago

:pushpin: Commit 4e4a5cd has been approved by MichaelHirn

homu commented 8 years ago

:umbrella: The latest upstream changes (presumably #23) made this pull request unmergeable. Please resolve the merge conflicts.

homu commented 8 years ago

:lock: Merge conflict