autumnai / leaf

Open Machine Intelligence Framework for Hackers. (GPU/CPU)
Apache License 2.0
5.56k stars 270 forks source link

Plans for compilation on Stable Rust? #40

Closed mitchmindtree closed 8 years ago

mitchmindtree commented 8 years ago

Hi!

I'm very interested in the ML field (though quite inexperienced). After having watched leaf from afar for a while, I thought I'd clone the repo and have a play!

The first thing that I noticed was that it currently relies on some unstable features. I'm curious: is there a certain set of heavily required unstable features that you're waiting on the stabilisation of before you plan to move to the stable channel? Or do you plan to follow the nightly in general, without minding the use of unstable features?

I'd love to contribute to leaf for a couple reasons: primarily as a way of learning more about ML, but also as I anticipate having a use-case for a strong rust ML library in the future, and from what I can tell, leaf looks like the most promising candidate for this so far :smile_cat: I'm not super interested in tracking nightly rust however (I started using rust around 0.9 and keeping up with the instability across all my projects really took the wind out of me.. haven't been able to bring myself to leave the stable channel since heheh).

MichaelHirn commented 8 years ago

Hi @mitchmindtree :wave:

Thank you so much for reaching out. Leaf 0.2.0 will build and run under Rust stable.

@skade elucidated us some weeks ago on the Berlin Rust meetup, on the advantages of the stable Rust channel. I think all other projects (collenchyma and it's plugins) build already under stable, as we started out to only support nightly Rust for our projects - which in hindsight, wasn't very clever, of course :smile:

I think it is a good idea, to make this an explicit issue for the 0.2.0 release. @hobofan is currently preparing for it and he might have more to add. I am going to close this issue for now, but feel free to comment on it here or on the stable issue I will open in a minute. You can also reach us anytime at the Leaf Gitter for a chat.

hobofan commented 8 years ago

As MJ said 0.2.0 will build on Rust stable, and my latest local version already does (which only required a very small change).

mitchmindtree commented 8 years ago

Awesome news :smile_cat: