search

autumnai / leaf

Open Machine Intelligence Framework for Hackers. (GPU/CPU)
Apache License 2.0
5.56k stars 272 forks source link

Fixed typo: crucial from curcial #79

Closed palerdot closed 8 years ago

palerdot commented 8 years ago

Changed typo from word curcial to crucial

GitCop commented 8 years ago

There were the following issues with your Pull Request

Guidelines are available at https://github.com/autumnai/leaf/blob/develop/CONTRIBUTING.md#git-commit-guidelines

This message was auto-generated by https://gitcop.com

palerdot commented 8 years ago

@GitCop I couldn't find the guidelines in the mentioned url

hobofan commented 8 years ago

@palerdot Thanks for the contribution! :+1: The correct link is this one: https://github.com/autumnai/leaf/blob/master/CONTRIBUTING.md#git-commit-guidelines

A fitting commit message for your commit would be docs/readme: crucial from curcial. The body of the commit message can stay the same.

palerdot commented 8 years ago

Thanks. will do from now on.

hobofan commented 8 years ago

Could you please also amend the commit message of this PR? :wink:

palerdot commented 8 years ago

Amended. Was that Ok ?

hobofan commented 8 years ago

Yes the commit message looks good now! :)

Due to some reasons Travis CI doesn't run the tests, but I think that's something I'll have to fix on our side.

hobofan commented 8 years ago

Oh, damn, sorry for not noticing earlier. You fixed the problem in the gh-pages branch. However the gh-pages branch just contains documentation that will be regenerated after every push to master. So if I would merge the PR right now the change would disapear very soon.

The actual origin of the generated documentation would be here: https://github.com/autumnai/leaf/blob/master/src/lib.rs#L59

palerdot commented 8 years ago

I have given another pull request to master branch with the required commit format. https://github.com/autumnai/leaf/pull/83