auxesis / cucumber-nagios

Systems testing plugin for Nagios with Cucumber + Webrat + Mechanize + Net::SSH
http://cucumber-nagios.org/
MIT License
257 stars 43 forks source link

http_header steps aren't parenthesized, throw warnings #32

Closed auxesis closed 13 years ago

auxesis commented 13 years ago

@tauboy wrote in #11:

Hi mate

getting an error running feature tests under 0.8.3

/home/cucumber/cucumber/infrastructure-tests/features/steps/http_header_steps.rb:16: warning: parenthesize argument(s) for future version /home/cucumber/cucumber/infrastructure-tests/features/steps/http_header_steps.rb:20: warning: parenthesize argument(s) for future version

to fix it I've had to hash out these 2 steps in http_header_steps.rb

header contains checks Then /the "(.)" header should contain "(.)"$/ do | header_name, header_contains | @url_headers[header_name].should match header_contains end

Then /the "(.)" header should not contain "(.)"$/ do | header_name, header_contains | @url_headers[header_name].should_not match header_contains end

auxesis commented 13 years ago

Fixed in 0.8.4 / 298adcb36b8e949c0b235e938530019a8441ad50.