auxesis / cucumber-nagios

Systems testing plugin for Nagios with Cucumber + Webrat + Mechanize + Net::SSH
http://cucumber-nagios.org/
MIT License
257 stars 43 forks source link

cucumber >1.1.2 API compatibility #90

Closed fpeterschmitt closed 6 years ago

fpeterschmitt commented 10 years ago

Hi,

I noticed that cucumber-nagios 0.9.2 (installed via gems) is not compatible with recent versions of cucumber. This is known and I've seen other bug reports.

In the after_step_result function I "puts" the 8° argument and it simply contains the line numbre in the feature file, and more precisely, the line of the scenario executed.

From where I am I cannot make a pull request, but I think it is ok to add an argument which will not be used, like this:

cucumber-nagios-0.9.2/lib/cucumber/formatter/nagios.rb:16:

def after_step_result(keyword, step_match, multiline_arg, status, exception, source_indent, background, scenario_line_number)

Then I think we should push a new version and the gem.

Thank you.