search

auxesis / visage

Graph collectd metrics in the browser, backed by a JSON API
http://visage-app.com/
Other
381 stars 56 forks source link

Load profiles from multiple files #62

Closed sciurus closed 11 years ago

sciurus commented 13 years ago

Currently all profiles are stored in a single configuration file, profiles.yaml. It would be nice if profiles could be loaded from multiple files; this would make generating visage configuration from other tools like puppet simpler.

auxesis commented 13 years ago

Good call. I think this makes a lot if sense.

Do you think a file per profile would be appropriate, or just make it arbitrary?

sciurus commented 13 years ago

Just making it arbitrary would be nicest.

auxesis commented 11 years ago

This is being actively worked on for Visage 3.0.

The profiles are being represented be a proper model that uses ActiveModel for all the validations + serialisations, so changing the implementation to use multiple files is pretty straight forward.

The main motivation for doing this is to make testing a little easier, but it'll definitely help in the config management scenario you outlined above @sciurus.

auxesis commented 11 years ago

This is implemented as of 191cca0fdcdd661349c09ca1f634d9ea41f9a52b and ff635d4e95bada977a77ec829531bb4d9ec39c7a.

Closing.