auxility / better-apk-expansion

Community maintained Android APK Expansion library
Apache License 2.0
27 stars 14 forks source link

No network connection #10

Open muellerr opened 6 years ago

muellerr commented 6 years ago

I'm currently writing my first android app that requires an expansion file. This library seems very interesting for this task. Unfortunately I'm having a bit of a hard time to get it running. On one device the app crashes right away and on another I noticed that the call to "DownloaderService.startDownloadServiceIfRequired" always returns the status NETWORK_NO_CONNECTION. Do you have any idea what might cause this behavior?

vadymhimself commented 6 years ago

@muellerr I believe that this issue is caused by the change of the targetSdkVersion. The library now requires runtime permissions. I will investigate this issue, thank you. As a temporary fix, you may want to ask the user for a runtime permission

muellerr commented 6 years ago

@bolein thank your for your reply. I have all necessary permissions in the app manifest file as described on the developers.android site. I thought these should suffice for network access. Which particular permission would I have to request at runtime?

vadymhimself commented 6 years ago

@muellerr I believe it's the external storage rw permission. I'll have to look closely to the issue to tell for sure

vadymhimself commented 6 years ago

Since I don't have much time currently, I'd ask @dhleong to also have a look at this

muellerr commented 6 years ago

@bolein thanks for your help. I actually added a check for rw permissions. They are both given so that does not resolve my problem.