av / harbor

Effortlessly run LLM backends, APIs, frontends, and services with one command.
https://github.com/av/harbor
Apache License 2.0
544 stars 37 forks source link

comfyui won't start due to :rshared #45

Closed lee-b closed 1 month ago

lee-b commented 1 month ago

Not sure what the purpose of rshared is in the comfy ui config -- multiple instances? I got the following error with it:

$ harbor up comfyui
WARN[0000] Found orphan containers ([harbor.plandex-server harbor.plandex-db harbor.plandex]) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up.
[+] Running 2/3
 ⠧ Container harbor.comfyui  Starting                                                                                                                                                              1.1s
 ✔ Container harbor.ollama   Running                                                                                                                                                               0.0s
 ✔ Container harbor.webui    Started                                                                                                                                                               0.9s
Error response from daemon: path /mnt/nvme1/home/lb/AI/harbor/comfyui/workspace is mounted on /mnt/nvme1 but it is not a shared mount

This patch fixes it:

diff --git a/compose.comfyui.yml b/compose.comfyui.yml
index 895508f..d97cd43 100644
--- a/compose.comfyui.yml
+++ b/compose.comfyui.yml
@@ -33,7 +33,7 @@ services:
       - ${HARBOR_COMFYUI_PORTAL_HOST_PORT}:${HARBOR_COMFYUI_PORTAL_HOST_PORT}
       - ${HARBOR_COMFYUI_SYNCTHING_HOST_PORT}:${HARBOR_COMFYUI_SYNCTHING_HOST_PORT}
     volumes:
-      - ./comfyui/workspace:/workspace:rshared
+      - ./comfyui/workspace:/workspace
       # - ./comfyui/storage:/storage
     networks:
       - harbor-network

But may break some other goal.

lee-b commented 1 month ago

Hmm. This may be a red herring, warning, not fatal error. Seems it won't ACTUALLY start regardless. Confirming.

av commented 1 month ago

Thanks for reporting nonetheless, this was a leftover from the initial testing, I removed it v0.2.1

av commented 1 month ago

Closing for now, feel free to follow-up if needed