search

ava-innersource / Liquid-Application-Framework-1.0-deprecated

Liquid is a framework to speed up the development of microservices
MIT License
25 stars 14 forks source link

fix: WorkBench is now correctly spelled as Workbench #145

Closed bruno-brant closed 4 years ago

bruno-brant commented 4 years ago

Changes the name of WorkBench class. I took care that this wouldn't necessarily break anything. Closes #9.

Also did a small fix on the throw instruction parameters. Closes #62.

We must first approve #141 before moving forward with this PR.

Oh, this should not have any breaking changes given that I haven't touched the sample and it's still working, but please reviewer, take a good look, since we're lacking tests.

guilhermeluizsp commented 4 years ago

There are some breaking changes since you've renamed some interfaces (ILightLogger inherits from IWorkbenchHealthCheck now, instead of IWorkBenchHealthCheck, for example), but I believe they are necessary, considering the goal of this pull request.

Everything looks great, but both ILightPolly and ILightWorker still inherits from the old IWorkBenchService interface (the misspelled one). They don't show up in the file changes because you haven't touched them, but I think they should be using the new one.

https://github.com/Avanade/Liquid-Application-Framework/blob/939759831f202b748565a454a2828477df4d0c45/src/Liquid.Base/Interfaces/Polly/ILightPolly.cs#L10

https://github.com/Avanade/Liquid-Application-Framework/blob/939759831f202b748565a454a2828477df4d0c45/src/Liquid.Base/Interfaces/MessageBus/ILightWorker.cs#L8

guilhermeluizsp commented 4 years ago

@bruno-brant I'm waiting for you to merge with the master branch since #141 is approved already.

bruno-brant commented 4 years ago

There are some breaking changes since you've renamed some interfaces (ILightLogger inherits from IWorkbenchHealthCheck now, instead of IWorkBenchHealthCheck, for example), but I believe they are necessary, considering the goal of this pull request.

Everything looks great, but both ILightPolly and ILightWorker still inherits from the old IWorkBenchService interface (the misspelled one). They don't show up in the file changes because you haven't touched them, but I think they should be using the new one.

https://github.com/Avanade/Liquid-Application-Framework/blob/939759831f202b748565a454a2828477df4d0c45/src/Liquid.Base/Interfaces/Polly/ILightPolly.cs#L10

https://github.com/Avanade/Liquid-Application-Framework/blob/939759831f202b748565a454a2828477df4d0c45/src/Liquid.Base/Interfaces/MessageBus/ILightWorker.cs#L8

Yeah, I realized that the IWorkbenchHealthCheck change is breaking, but I also guessed that it wouldn't be a big problem for users since, well, they shouldn't be accessing a ILightLogger cast to a IWorkbenchHealthCheck. I know that it's a possibility, but it's one I'm okay with.

Now, both polly and worker are just things that I ended up forgetting. I'll make the necessary fixes.

bruno-brant commented 4 years ago

Also, both Polly and Worker will be made obsolete very soon. :)

bruno-brant commented 4 years ago

Done, @guilhermeluizsp. The branch is rebased.