search

ava-innersource / Liquid-Application-Framework-1.0-deprecated

Liquid is a framework to speed up the development of microservices
MIT License
25 stars 14 forks source link

AwdSqsSns.HealthCheck is broken #181

Closed bruno-brant closed 4 years ago

bruno-brant commented 4 years ago

The code:

https://github.com/Avanade/Liquid-Application-Framework/blob/fc9edb95da074b98df7a75479633471f230b776d/src/Liquid.OnAWS/MessageBuses/AwsSqsSns.cs#L199

Doesn't awaits the result, so, it never checks whether or not SQS is answering.

Furthermore, the code:

https://github.com/Avanade/Liquid-Application-Framework/blob/fc9edb95da074b98df7a75479633471f230b776d/src/Liquid.OnAWS/MessageBuses/AwsSqsSns.cs#L212

Doesn't awaits the result, so, it never checks whether or not SNS is answering.