ava-innersource / Liquid-Application-Framework-1.0-deprecated

Liquid is a framework to speed up the development of microservices
MIT License
25 stars 13 forks source link

ServiceBus.HealthCheck sends a message to the bus? #186

Closed bruno-brant closed 4 years ago

bruno-brant commented 4 years ago

The code below is supposed to check if the connection with the ServiceBus is alive:

https://github.com/Avanade/Liquid-Application-Framework/blob/fc9edb95da074b98df7a75479633471f230b776d/src/Liquid.OnAzure/MessageBuses/ServiceBus.cs#L231-L235

As we can see, it posts a message to the bus and then tries to cancel it; there are multiple ways this can fail and leave a corrupt message to the clients.