search

ava-innersource / Liquid-Application-Framework-1.0-deprecated

Liquid is a framework to speed up the development of microservices
MIT License
25 stars 14 forks source link

The source code has duplicate implementations of LocalizationConfig #192

Open guilhermeluizsp opened 4 years ago

guilhermeluizsp commented 4 years ago

The one located at the Domain project is not being used at all.

https://github.com/Avanade/Liquid-Application-Framework/blob/ac834f46809cd445dda8783ff616ea4ae7af6b33/src/Liquid.Runtime/Localization/LocalizationConfig.cs#L9-L27

https://github.com/Avanade/Liquid-Application-Framework/blob/ac834f46809cd445dda8783ff616ea4ae7af6b33/src/Liquid.Domain/Localization/LocalizationConfig.cs#L9-L18

bruno-brant commented 4 years ago

How do we know that the Domain's one isn't being used?

guilhermeluizsp commented 4 years ago

I searched for its references across the source code

bruno-brant commented 4 years ago

But couldn't our users be using this one?

guilhermeluizsp commented 4 years ago

Unfortunately, yes...I think we can just make it as obsolete and remove it later on.