search

ava-innersource / Liquid-Application-Framework-1.0-deprecated

Liquid is a framework to speed up the development of microservices
MIT License
25 stars 14 forks source link

feat(ServiceBus): adds unit tests #197

Open bruno-brant opened 4 years ago

bruno-brant commented 4 years ago

Should only be approved after #217 and #210.

bruno-brant commented 4 years ago

Hey @guilhermeluizsp could I get your input here?

There's a test failing in this PR - it seems that the DLR is failing to resolve (bind) to a property of a dynamic type. Do you have any idea why? What am I missing?

guilhermeluizsp commented 4 years ago

@bruno-brant Yeah. The Foobar class is private so its members are only visible to the LightWorkerTests class. Even the default DLR binder does not bypass access modifiers.

We can either make it public to make the binder work correctly, or create a custom DynamicObject to invoke inaccessible members.

bruno-brant commented 4 years ago

@guilhermeluizsp huh, would've never guessed that was the problem, but surely it's simple enough, I will make the class public.

guilhermeluizsp commented 4 years ago

@bruno-brant I was supposed to review this PR a long time ago, I'm really sorry for that. May you please rebase with the master branch (so I can begin to review it)? I'm seeing things from previous PRs that were merged already.

bruno-brant commented 4 years ago

@bruno-brant I was supposed to review this PR a long time ago, I'm really sorry for that. May you please rebase with the master branch (so I can begin to review it)? I'm seeing things from previous PRs that were merged already.

Oh, no worries, it is still work in progress.

You are correct, I probably need to work some git magic here, because I've rebased a number of branches after branching this one...

I will do this shortly. I do want your opinion. I was unable to do testing on ServiceBus without refactoring it, at least a little. And there's a dirty hack on a test that you'll probably despise, but I believe we can live with it until we rewrite this class / the whole LightWorker approach.