search

ava-innersource / Liquid-Application-Framework-1.0-deprecated

Liquid is a framework to speed up the development of microservices
MIT License
25 stars 13 forks source link

ServiceBus completes messages even when ReceiveMode is ReadAndDelete #199

Open bruno-brant opened 4 years ago

bruno-brant commented 4 years ago

You are only supposed to call CompleteMessage if the receive mode is PeekLock, but ServiceBus is calling the method unconditionally.

https://github.com/Avanade/Liquid-Application-Framework/blob/f312143f5daf023eeb7c62b4f6bbdef7d1a24c94/src/Liquid.OnAzure/MessageBuses/ServiceBus.cs#L93

More information: https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-performance-improvements#receive-mode

bruno-brant commented 4 years ago

I'm marking this issue as priority because it's affecting one of our customers.