ava-innersource / Liquid-Application-Framework-1.0-deprecated

Liquid is a framework to speed up the development of microservices
MIT License
25 stars 13 forks source link

CosmosDB class does not override LightRepository's GetAsync<T>() method #214

Open guilhermeluizsp opened 4 years ago

guilhermeluizsp commented 4 years ago

LightRepository has two virtual methods for retrieving a collection of entities. They are GetAsync<T>(Expression<Func<T, bool>> predicate), and GetAsync<T>() (I assume y'all know their difference given their signatures). CosmosDB only overrides the former.

So, if we want to retrieve every entity from a collection, we must do something like this:

Repository.GetAsync(x => true);
bruno-brant commented 4 years ago

Marked as priority because this is causing issues with a customer.

bruno-brant commented 4 years ago

After looking into this, my take is that we should remove these bogus implementations from the base class since they are introducing problems rather than solving.