search

ava-innersource / Liquid-Application-Framework-1.0-deprecated

Liquid is a framework to speed up the development of microservices
MIT License
25 stars 14 forks source link

WIP: feat(CosmosDb): Enabling the definition of PartitionKey #216

Closed andreracz closed 4 years ago

andreracz commented 4 years ago

Created the fix for issue #200, WIP as the tests are missing

guilhermeluizsp commented 4 years ago

@andreracz GitHub is telling is there are conflicts to be resolved. May you please rebase onto master?

@bruno-brant Are we really going to take this approach? We had an internal discussion about this topic, talking about making it configurable/extensible so we could choose the appropriate partition key for each collection. Should approve it and always use id (at least for now)?

bruno-brant commented 4 years ago

@guilhermeluizsp sorry, I forgot to close this issue.

You're completely right - although at first we considered this approach, we've realized that setting the id as the partition key would result in (almost) always making cross partition queries.

I'm closing this PR for now while we work on the preferable solution.