search

ava-labs / avalanche-cli

Other
105 stars 67 forks source link

avalanche-cli fails updating submodules for avalanche-interchain-token-transfer #2133

Open chrisfusillo opened 2 months ago

chrisfusillo commented 2 months ago

There may be a bug in the avalanche-cli for pulling the ICTTURL.

https://github.com/ava-labs/avalanche-cli/blob/4c5be38f8a26efd5b29d6c41cbd8f361d1094239/pkg/ictt/build.go#L133

 cmd := exec.Command(
  "git",
  "submodule",
  "update",
  "--init",
  "--recursive",
  "--single-branch",
 )

"--single-branch" isn't a proper usage flag, so it errors.

Reproduce:

  1. Execute: avalanche interchain tokenTransferrer deploy
  2. Step: Downloading Avalanche InterChain Token Transfer Contracts
  3. Results in:
  4. Error: could not update submodules of repository https://github.com/ava-labs/avalanche-interchain-token-transfer: exit status 1

Reproduced: avalanche-cli v1.7.1 & v1.7.0

chrisfusillo commented 2 months ago

I have confirmed that by removing "--single-branch" the error no longer occurs and the command proceeds to the next step.

felipemadero commented 2 months ago

Hi! I currently can't reproduce the issue. May it depend on git version? Just tested with 2.39.3. Which version are you using?

chrisfusillo commented 2 months ago

Hi! I currently can't reproduce the issue. May it depend on git version? Just tested with 2.39.3. Which version are you using?

2.39.5