search

ava-labs / avalanche-faucet

Avalanche Faucet for Fuji Network and Subnets.
https://faucet.avax.network/
Other
472 stars 211 forks source link

Replace MetaMask references to generic wallet #83

Open george-gkas opened 1 year ago

george-gkas commented 1 year ago

👋 Hello, Ava Labs team. My name is George, and I'm a Frontend Engineer on the Web Extension team of Trust Wallet. We are currently implementing support for testnet faucets into our browser extension wallet, and we would like to redirect our users to https://faucet.avax.network/.

Unfortunately, the current state of https://faucet.avax.network/ presents a MetaMask icon for establishing a wallet connection or adding new networks. This is misleading because users can still use any wallet to interact with the website (e.g., Trust Wallet, Coinbase Wallet, Brave Wallet, etc.). For that reason, we'd like to propose the change of the MetaMask icon to a generic one. In addition, users will be redirected to https://ethereum.org/en/wallets/find-wallet/ rather than MetaMask's website if they still need to install a wallet.

We have already implemented the proposed changes and will open a PR soon. We strongly believe that they will positively impact the project and the community. Below, I've shared a screenshot of the new UI using the generic icon. We are open to talks and any questions you might have. 🚀

Screenshot 2023-02-15 at 11 50 38 AM
nahoc commented 1 year ago

Have you tried looking into https://core.app/tools/testnet-faucet/ -- it's another "official" implementation of the Faucet

george-gkas commented 1 year ago

Hello @nahoc10 , we did yes, but we concluded that this implementation is a better choice due to its simple UI and the fact that it does not reference other organizations like https://core.app/tools/testnet-faucet/ does with Core.

https://faucet.avax.network/ is just a faucet that provides a universal connect option and no other integrated tools, which is exactly what we are looking for.