ava-labs / avalanchego

Go implementation of an Avalanche node.

https://avax.network

BSD 3-Clause "New" or "Revised" License

2.12k stars 667 forks source link

Add CI check that auto-generated code is up to date. #1553

Closed StephenButtolph closed 1 year ago

StephenButtolph commented 1 year ago

1472 was incorrectly merged (without regenerating the `pb` files). Currently we use auto generated code for our test mocks (`mockgen`) and for our proto (`buf`) message definitions.

We should add a CI check (perhaps 2 separate workflows) that ensures that

[x] running ./scripts/protobuf_codegen.sh does not change any files.
[x] running ./scripts/mock.gen.sh does not change any files.

github-actions[bot] commented 1 year ago

This issue has become stale because it has been open 60 days with no activity. Adding the lifecycle/frozen label will cause this issue to ignore lifecycle events.

ava-labs / avalanchego

Add CI check that auto-generated code is up to date. #1553

1472 was incorrectly merged (without regenerating the pb files). Currently we use auto generated code for our test mocks (mockgen) and for our proto (buf) message definitions.

1472 was incorrectly merged (without regenerating the `pb` files). Currently we use auto generated code for our test mocks (`mockgen`) and for our proto (`buf`) message definitions.