This is the last PR to remove usage of .Status() from the block type in the production consensus engine. There is still one usage of the call in the bootstrapping logic.
How this works
Two of the calls to .Status() were just logging related which can easily be removed.
One of the calls to .isDecided() wasn't required.
The last call to .isDecided() can easily just use the height. This is fairly straightforward, as getProcessingAncestor is really only used in a best-effort context now that we require the preferredBlockAtHeight to be populated in chits messages.
Why this should be merged
This is the last PR to remove usage of
.Status()from the block type in the production consensus engine. There is still one usage of the call in the bootstrapping logic.How this works
.Status()were just logging related which can easily be removed..isDecided()wasn't required..isDecided()can easily just use the height. This is fairly straightforward, asgetProcessingAncestoris really only used in a best-effort context now that we require thepreferredBlockAtHeightto be populated inchitsmessages.How this was tested