cleanup: shorten upgrade names

ava-labs / coreth

Code and wrapper to extract Ethereum blockchain functionalities without network/consensus, for building custom blockchain services.

Other

183 stars 139 forks source link

cleanup: shorten upgrade names #605

Open darioush opened 3 months ago

darioush commented 3 months ago

Why this should be merged

I think "UpgradeTime" is sufficiently expressive and shorter than "UpgradeBlockTimestamp"

How this works

Renames things, should not impact deployed chains since these values are specified by the avalanchego times not the genesis

How this was tested

darioush commented 3 months ago

In subnet-evm, we have:

    SubnetEVMTimestamp *uint64 `json:"subnetEVMTimestamp,omitempty"`
    DurangoTimestamp *uint64 `json:"durangoTimestamp,omitempty"`
    EUpgradeTimestamp *uint64 `json:"eUpgradeTimestamp,omitempty"`

What do you recommend for consistency here?

Notably we have durangoTimestamp vs durangoBlockTimestamp (in coreth)

ceyonur commented 3 months ago

In subnet-evm, we have:
  SubnetEVMTimestamp *uint64 `json:"subnetEVMTimestamp,omitempty"`
  DurangoTimestamp *uint64 `json:"durangoTimestamp,omitempty"`
  EUpgradeTimestamp *uint64 `json:"eUpgradeTimestamp,omitempty"`
What do you recommend for consistency here?

Notably we have durangoTimestamp vs durangoBlockTimestamp (in coreth)

I'd say durangoTimestamp

ceyonur commented 3 months ago

After looking at Subnet-EVM code, I think it's probably best to go with xxxTimestamp as it's almost not possible to rename those JSON fields in Subnet-EVM.

darioush commented 2 months ago

going to move this to draft for now until I fix it up.