search

ava-labs / firewood

Compaction-Less Database Optimized for Efficiently Storing Recent Merkleized Blockchain State
https://ava-labs.github.io/firewood/
Other
117 stars 10 forks source link

change `HashPreimage` children type #663

Closed danlaine closed 4 months ago

danlaine commented 5 months ago

Is this cleaner? I'm not sure so I'm making a separate PR. I hate checking whether a hash is default::Default(). I'd rather see if it's None. That's why I think having an array of options might be better than having an option of an array.

@rkuris If you strongly disagree feel free to close.

danlaine commented 4 months ago

closed in favor of https://github.com/ava-labs/firewood/pull/669