latest_revision shouldn't return an Option, since there is always one

ava-labs / firewood

Compaction-Less Database Optimized for Efficiently Storing Recent Merkleized Blockchain State

https://ava-labs.github.io/firewood/

Other

117 stars 10 forks source link

latest_revision shouldn't return an Option, since there is always one #700

Closed rkuris closed 1 month ago

rkuris commented 2 months ago

          Is it an invariant that there is always at least one historical revision? If so, should the return type for `latest_revision` be `Arc<NodeStore<Committed, FileBacked>>` and not `Option<Arc<NodeStore<Committed, FileBacked>>>`?

_Originally posted by @danlaine in https://github.com/ava-labs/firewood/pull/697#discussion_r1702046461_

rkuris commented 1 month ago

Fixed in #709