search

ava-labs / hypersdk

Opinionated Framework for Building Hyper-Scalable Blockchains on Avalanche
Other
200 stars 105 forks source link

nit: Add the `Gas` type in the `max_units` field of `Step` #1006

Open iFrostizz opened 4 months ago

iFrostizz commented 4 months ago

There might be a bit of code moves before addressing this one, since we don't want to import wasmlanche-sdk just for the Gas type (yet? maybe that would make sense in the future)

          This might be a leftover https://github.com/ava-labs/hypersdk/blob/ff05db9eb56935fc964c0a88397269312e9dce8e/x/programs/cmd/simulator/src/lib.rs#L43 and I also don't know why we would have this type being a `u64`. I guess that it would still work if you replace by `Gas` here since the bitwise representation of positive numbers *should* almost be the same (except when it grows large)

Originally posted by @iFrostizz in https://github.com/ava-labs/hypersdk/issues/1005#issuecomment-2145629397

github-actions[bot] commented 1 month ago

This issue has become stale because it has been open 60 days with no activity. Adding the lifecycle/frozen label will exempt this issue from future lifecycle events.