add a checksum to the hex address format (ideally similar to EIP55).

ava-labs / hypersdk

Opinionated Framework for Building Hyper-Scalable Blockchains on Avalanche

Other

200 stars 105 forks source link

add a checksum to the hex address format (ideally similar to EIP55). #1570

Open github-actions[bot] opened 2 weeks ago

github-actions[bot] commented 2 weeks ago

Line: 13 https://github.com/ava-labs/hypersdk/blob/fd4111b44db9a3d27284a9c65e33784617428d3c/codec/address.go#L10-L20

aaronbuchwald commented 2 weeks ago

https://github.com/ethereum/ERCs/blob/5a1ad45179a6a95cbcd7be67b904a5e5c679bb07/ERCS/erc-55.md

We should implement a checksum on the address as a bare minimum.

Removed bech32 because it makes the UX worse (don't recognize the same address across different chains) and DevX worse (need to pass around contextual information to display/parse addresses).

For this issue, we should re-evaluate what default address format we want and see about enabling VMs to optionally override it.