[ci] Commit to `ginkgo` or replace with `go test`

ava-labs / hypersdk

Opinionated Framework for Building Hyper-Scalable Blockchains on Avalanche

https://hypersdk.xyz/

Other

190 stars 94 forks source link

Open patrick-ogrady opened 1 month ago

patrick-ogrady commented 1 month ago

It is unclear if we really need to rely on ginkgo for integration/e2e or if we can get by with out-of-the-box golang testing.

golang testing has come a long way since ginkgo was released (both adding parallelism + subtests): https://onsi.github.io/ginkgo/#why-ginkgo (https://go.dev/blog/subtests)

patrick-ogrady commented 1 month ago

In isolation, my view at this moment is that normal go testing is sufficient (with testify) but am open to other perspectives.

marun commented 1 week ago

Ginkgo wins for me for integration/e2e:

test discovery without execution (dry run). stdlib can only filter as part of execution.
parallel execution support is simpler to enable - implicit (but possible to disable) vs explicit for stdlib.
fixture can be shared across package boundaries. This is not supported by stdlib.