ava-labs / icm-services

Services for relaying Avalanche ICM messages between L1s
Other
24 stars 19 forks source link

Rename away from warp #551

Closed iansuvak closed 5 days ago

iansuvak commented 2 weeks ago

Why this should be merged

Part of general renaming from Warp -> ICM. Closes #538

How this works

One inconsistency right now is module/repo name having a dash in Off-chain in plain text but no dash in the module and proposed repo name. I can change either to make it consistent but icm-off-chain-services seems like too many dashes for a module/repo name IMO.

How this was tested

Existing tests should pass. Once the repo is created it should be tested with new test tags.

How is this documented

Updated the docs

geoff-vball commented 1 week ago

Just as a note before I start reviewing. I do like icm-offchain-services and ICM Off-chain Services. 3 dashes is too many

cam-schultz commented 1 week ago

Thoughts on condensing the name to icm-service? IMO the shorter the repo name the better. I think it should be pretty obvious from the lack of smart contracts that these services are not "on chain", so the "off chain distinction" feels superfluous. In the wider context of the soon-to-be-named icm-contracts repo, having this repo be named similarly emphasizes their relationship.

iansuvak commented 1 week ago

Thoughts on condensing the name to icm-service? IMO the shorter the repo name the better. I think it should be pretty obvious from the lack of smart contracts that these services are not "on chain", so the "off chain distinction" feels superfluous. In the wider context of the soon-to-be-named icm-contracts repo, having this repo be named similarly emphasizes their relationship.

I like icm-services