avacore1337 / OneLife

My Vue/WASM/Rust idle game
https://avacore1337.github.io/OneLife/
MIT License
1 stars 2 forks source link

update from pinned nightly rustc to unpinned stable #6

Closed dimitrilw closed 1 year ago

dimitrilw commented 1 year ago

Also:

Code compiles & passes tests.

dimitrilw commented 1 year ago

Thank you. 😊

I'm really green with Rust, so I am 100% positive that I'll make a lot of mistakes along the way. For all I know, the changes I made might alter our benchmark performance -- I haven't done any benchmarking -- or some other negative side-effect. But it felt good to make those changes. 😄

Thank you for the positive feedback.

avacore1337 commented 1 year ago

The rust code is crazy efficient (but only in release mode) so not too worried about performance there. I tried two different serialization strategies, but they were about the same. Only note though regarding performance is that if the code uses less than 1% of a core when the page is in the background you won't be throttled in the same way. Really important to make the game run well for something like an idle game. Btw, if you really wanna give this a go and contribute, I'll try to write down something regarding some of my design choices, just so you have a reference.

avacore1337 commented 1 year ago

You should also know I have a vue3 game also that I worked on after this: https://github.com/avacore1337/tower-idle Didn't get as far with content there though, but it is typescript which is good if you like that. It also has a newer toolchain for javascript since I started on that later.

dimitrilw commented 1 year ago

I really appreciate all the thoughts you have. Thank you. Just eager to learn and improve.