search

avadev / AvaTax-REST-V2-DotNet-SDK

AvaTax v2 SDK for languages using the Dot Net Framework
Apache License 2.0
28 stars 37 forks source link

Add an interface for AvaTaxClient #68

Closed mweylandcliq closed 1 year ago

mweylandcliq commented 6 years ago

Please expose an interface for the AvaTaxClient. In order to build out proper unit test and allow a AvaTaxClient instance to be injectable this should really implement an interface.

MattMinke commented 5 years ago

It would also be nice to have some interface segregation. https://en.wikipedia.org/wiki/Interface_segregation_principle

svc-developer commented 2 years ago

Thanks for the suggestion. We will review this idea.

nls-aarndt commented 1 year ago

Hi, any update on this? Seems like there is a PR that was submitted about two years ago that is still open (but with conflicts now)

https://github.com/avadev/AvaTax-REST-V2-DotNet-SDK/pull/153

We need an interface on the AvaTaxClient in order to mock it in unit tests.

svc-developer commented 1 year ago

I think this got closed by accident, will review it.

svc-developer commented 1 year ago

Released with 24.4.1, please check it out